Set custom webdriver port with ENV var and checking port availability#1124
Open
usernameComputer01 wants to merge 3 commits intophp-webdriver:mainfrom
Open
Set custom webdriver port with ENV var and checking port availability#1124usernameComputer01 wants to merge 3 commits intophp-webdriver:mainfrom
usernameComputer01 wants to merge 3 commits intophp-webdriver:mainfrom
Conversation
usernameComputer01
commented
Mar 28, 2025
Chrome: WEBDRIVER_CHROME_CUSTOM_PORT
Firefox: WEBDRIVER_FIREFOX_CUSTOM_PORT
0004ebf to
3fc6650
Compare
Collaborator
|
Does such env exist in another project ? |
Author
I didn't find any information on the ENV standard for webdriver. |
b893e92 to
153a1ad
Compare
153a1ad to
f055eec
Compare
Author
|
Added checking for availability of listening port |
williamdes
reviewed
Mar 31, 2025
williamdes
reviewed
Mar 31, 2025
Co-authored-by: William Desportes <williamdes@wdes.fr>
williamdes
approved these changes
Oct 1, 2025
Collaborator
williamdes
left a comment
There was a problem hiding this comment.
Looks okay, @OndraM ?
OndraM
requested changes
Dec 16, 2025
Collaborator
OndraM
left a comment
There was a problem hiding this comment.
Thanks! Could you please update the sockets dependency? 🙏
| /** | ||
| * @throws RuntimeException | ||
| */ | ||
| protected static function checkPortIsAvail(int $port) |
Collaborator
There was a problem hiding this comment.
Suggested change
| protected static function checkPortIsAvail(int $port) | |
| protected static function checkPortIsAvailable(int $port) |
No need for shortcuts :)
| */ | ||
| protected static function checkPortIsAvail(int $port) | ||
| { | ||
| $errTest = static function ($sock) use ($port) { |
Collaborator
There was a problem hiding this comment.
This method should check if the Sockets extension is enabled, and if not, it should just return true (ie. the same behavior as before - without free port detection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.