Skip to content

throw on null bytes / resolve GH-13952#18320

Closed
divinity76 wants to merge 8 commits intophp:masterfrom
divinity76:pdo-sqlite-quote-null-throw
Closed

throw on null bytes / resolve GH-13952#18320
divinity76 wants to merge 8 commits intophp:masterfrom
divinity76:pdo-sqlite-quote-null-throw

Conversation

@divinity76
Copy link
Contributor

@divinity76 divinity76 commented Apr 13, 2025

fix a corruption issue where PDO::quote for SQLite would silently truncate strings with null bytes in them,
by throwing.

resolve GH-13952
close GH-13972

@divinity76
throw on null bytes / resolve phpGH-13952
c1b07f4 
fix a corruption issue where PDO::quote for SQLite would silently truncate strings with
null bytes in them,
 by throwing.

resolve phpGH-13952
close phpGH-13972
ndossche
ndossche requested changes Apr 13, 2025
View reviewed changes
ndossche
ndossche requested changes Apr 13, 2025
View reviewed changes
ndossche
ndossche approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @SakiTakamachi 's final approval, but this LGTM

SakiTakamachi
SakiTakamachi approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked for a suitable SQL state, but couldn’t find one that fits well, so the current code seems to be the best option, thanks!

edit:
I’m out right now, but if it hasn’t been merged by the time I get back, I’ll merge it then :)

@divinity76
Copy link
Contributor Author

divinity76 commented Apr 14, 2025 •
edited
Loading

maybe sqlstate 22004 22029?

quoting ansi SQL:2011 draft at https://web.archive.org/web/20230525220603if_/https://www.wiscorp.com/sql20nn.zip
7IWD2-02-Foundation-2011-12.pdf

13.3 <externally-invoked procedure>
(...)
 constant SQLSTATE_TYPE :="22029";
    DATA_EXCEPTION_NULL_VALUE_NOT_ALLOWED:

or maybe 39000

 constant SQLSTATE_TYPE :="39000";
    EXTERNAL_ROUTINE_INVOCATION_EXCEPTION_NULL_VALUE_NOT_ALLOWED
  • final released ansi sql standards cost like 600USD, while drafts are available for free.

@SakiTakamachi
Copy link
Member

SakiTakamachi commented Apr 14, 2025

In my view, none of them seem appropriate.
I interpret “null value” as referring to a value that is null itself, not a value that contains null.

Also, I’m not sure whether this can be referred to as an “external routine.”

@SakiTakamachi
Copy link
Member

SakiTakamachi commented Apr 14, 2025

Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndossche ndossche ndossche approved these changes

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

Assignees

No one assigned

Labels

Extension: pdo_sqlite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite PDO::quote silently corrupts strings with null bytes

3 participants

@divinity76 @SakiTakamachi @ndossche