[TVOS] Adds the -fembed-bitcode flag to build script.#32
Merged
phoboslab merged 2 commits intophoboslab:masterfrom Oct 22, 2015
Merged
[TVOS] Adds the -fembed-bitcode flag to build script.#32phoboslab merged 2 commits intophoboslab:masterfrom
phoboslab merged 2 commits intophoboslab:masterfrom
Conversation
added 2 commits
October 21, 2015 15:36
… can be used while archiving tvOS builds.
…lt) to avoid issues while building from command line for tvOS.
Owner
|
Awesome, thanks! |
phoboslab
added a commit
that referenced
this pull request
Oct 22, 2015
[TVOS] Adds the -fembed-bitcode flag to build script.
phoboslab
added a commit
that referenced
this pull request
Oct 22, 2015
Owner
|
To keep the filesize for the compiled lib below 100mb (so we can push it to github), I had to disable bitcode generation for the simulator build. |
Contributor
Author
|
Yup, that makes sense since embedding bitcode is only useful when uploading builds to the app store, which cannot be done for simulator builds. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this flag allows the resulting library to be used while archiving builds for tvOS.