Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stepcode/stepcode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pcjc2/stepcode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 29 files changed
  • 1 contributor

Commits on Apr 19, 2015

  1. Fix use-after free of various fundamental types which are effectively… 

    … singletons.

We should not delete these in the Registry destructor, as other registry classes
may still need them.

A better fix would be tostatically initialise them, as suggested by Mark Pictor.

Fixes: #327
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    495bcd6 View commit details
    Browse the repository at this point in the history

  2. Fix assigning an Entity reference attribute with the late bound API 

    If the (SDAI_Application_instance * ) pointer already exists, it
may well have been assigned by the early-bound class initialiser to
point into an instance of its class type.

We should not delete that pointer, rather just alter its contents.
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    208f3ef View commit details
    Browse the repository at this point in the history

  3. Fixup AP214 schema ENTITY conversion_based_unit 

    The schema currently in use for AP214e3 contains a change that turned out
to be a mistake causing breakage of old files, and was subsequently
reverted prior to publication of the standard

The published schema doesn't appear to have been corrected, so in the mean
time, this fix corrects things to match the ammended section from Part 42.

(This change removes DERIVED rule for dimensions attribute, and replaces
it with a WHERE clause checking the explict attribute matches the intended
derivation.)
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    f444958 View commit details
    Browse the repository at this point in the history

  4. Fix inconsistent sort order compared to ISO-10303-21 standard 

    This manifested in incorrect complex entity ordering in some cases. For
example, a complex containing a BOUNDED_SURFACE and B_SPLINE_SURFACE entity
would emit them in the incorrect order. (This was picked up upon loading
SCL created files in the IDA-step viewer).

Fixes: #330
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    5afbfae View commit details
    Browse the repository at this point in the history

  5. Fix potential buffer overrun in PrettyTmpName

    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    c6a0ab0 View commit details
    Browse the repository at this point in the history

  6. Correct an erroneous comment regarding removal of _ characters by Pre… 

    …ttyTmptName
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    f47a433 View commit details
    Browse the repository at this point in the history

  7. Fix offsetting of entity name references in multi-dimensional aggregates 

    Multi-dimensional aggregates are not fully implemented in SCL, and instead
are read as strings. (In SCLundefined classes).

Augment the parsing code to pick out '#' characters indicating an entity
reference, and special-case read these WITH the correct file-offset.

Fixes reading entities with LIST of LIST of ENTITY type attributes at non-zero
file-offset. In particular, fixes reading of B_SPLINE_SURFACE attribute
"control_points_list".

Fixes: #331
    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    17aaffc View commit details
    Browse the repository at this point in the history

  8. Local changes, including fun test program

    Peter Clifton committed Apr 19, 2015
    Configuration menu
    Copy the full SHA
    50991f7 View commit details
    Browse the repository at this point in the history
Loading