update build-tag to use an alternate source for version number - #336
Merged
Merged
Conversation
pwtyler
force-pushed
the
fix-failed-release
branch
from
April 9, 2023 02:03
c0e9099 to
1861ac1
Compare
pwtyler
marked this pull request as ready for review
April 9, 2023 02:05
jspellman814
approved these changes
Apr 9, 2023
pwtyler
added a commit
that referenced
this pull request
Apr 9, 2023
Merged
pwtyler
added a commit
that referenced
this pull request
Apr 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging of #335 did not tag correctly, and the tag for https://github.com/pantheon-systems/wp-saml-auth/releases/tag/2.1.2 is missing the vendor directory, breaking on install/update.
This grabs the version number from README instead. tested with a one-off (now squashed) workflow here: https://github.com/pantheon-systems/wp-saml-auth/actions/runs/4648184638/jobs/8225707970