Some comments on the code in utils.pyx and string_utils.pyx.

cztomczak · cztomczak · commit f69b05b20c71 · 2014-01-09T19:13:39.000+01:00
And a comment about basestring usage.
diff --git a/cefpython/imports.pyx b/cefpython/imports.pyx
@@ -31,6 +31,12 @@ import weakref
 
 # We should allow multiple string types: str, unicode, bytes.
 # PyToCefString() can handle them all.
+# Important:
+#   If you set it to basestring, Cython will accept exactly(!)
+#   str/unicode in Py2 and str in Py3. This won't work in Py3
+#   as we might want to pass bytes as well. Also it will
+#   reject string subtypes, so using it in publi API functions
+#   would be a bad idea.
 ctypedef object py_string
 
 # You can't use "void" along with cpdef function returning None, it is planned to be
diff --git a/cefpython/string_utils.pyx b/cefpython/string_utils.pyx
@@ -2,7 +2,12 @@
 # License: New BSD License.
 # Website: http://code.google.com/p/cefpython/
 
-# @TODO: make this configurable through ApplicationSettings.
+# TODO: cleanup the code in string_utils.pyx and string_utils_win.pyx,
+#       see this topic for a review of the code in this file, see the
+#       posts by Stefan Behnel:
+#       https://groups.google.com/d/topic/cython-users/VICzhVn-zPw/discussion
+
+# TODO: make this configurable through ApplicationSettings.
 UNICODE_ENCODE_ERRORS = "replace"
 BYTES_DECODE_ERRORS = "replace"
 
diff --git a/cefpython/utils.pyx b/cefpython/utils.pyx
@@ -17,6 +17,11 @@ cpdef py_bool IsString(object maybeString):
 cpdef py_bool IsThread(int threadID):
     return bool(CefCurrentlyOn(<CefThreadId>threadID))
 
+# TODO: this function needs to accept unicode strings, use the
+#       logic from wxpython.py/ExceptHook to handle printing
+#       unicode strings and writing them to file (codecs.open).
+#       This change is required to work with Cython 0.20.
+
 cpdef object Debug(str msg):
     if not g_debug:
         return
@@ -29,7 +34,7 @@ cpdef object Debug(str msg):
         except:
             print("cefpython: WARNING: failed writing to debug file: %s" % (
                     g_debugFile))
-                    
+
 
 cpdef str GetSystemError():
     IF UNAME_SYSNAME == "Windows":
@@ -75,7 +80,7 @@ cpdef str GetModuleDirectory():
     else:
         path = os.getcwd()
     if platform.system() == "Windows":
-        # On linux this regexp would give: 
+        # On linux this regexp would give:
         # "\/home\/czarek\/cefpython\/cefpython\/cef1\/linux\/binaries"
         path = re.sub(r"[/\\]+", re.escape(os.sep), path)
     path = re.sub(r"[/\\]+$", "", path)
