feat(encoding): support BOM detection with test passed#6074
Merged
Conversation
Electroid
force-pushed
the
fix/add_ignoreBOM_getter
branch
from
October 3, 2023 17:27
226d4c4 to
196491a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sorry for the delay, after support ignoreBOM in TextDecoder, decoder default behavior is remove BOM, so in the test, we should set to true, to pass the test with BOM.
I have rerun all test releated to TextDecoder, but for the stability, I think we should wait the CI to finish all test before merge.
Support BOM detection and
TextDecoder.ignoreBOM.Releated PR/Commit:
feat(encoding): support BOM detection #5550
Revert "feat(encoding): support BOM detection (https://github.com/oven-sh/bun/pull/5550)"
Code changes
How did you verify your code works?