Skip to content

'fix the warnings from 'is not 0' to '!= 0' in management.py #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwass merged 1 commit into from
Apr 12, 2022
Merged

'fix the warnings from 'is not 0' to '!= 0' in management.py #82

zwass merged 1 commit into from
Apr 12, 2022

Conversation

@bpmcdevitt
Copy link
Contributor

@bpmcdevitt bpmcdevitt commented Apr 24, 2021 •
edited
Loading

I am working on a project where I am using this python library in a Windows and Linux environment. It is super convenient for getting python to communicate with osqueryd.

I am using this module with Python version 3.9 in my environment and I am receiving the following warnings referencing the management.py file:

In [1]: from osquery_interface import OsqueryInterface
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:186: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if status.code is not 0:
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:243: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if status.code is not 0:
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:295: SyntaxWarning: "is not" with a literal. Did you mean "!="?

This PR will fix those warnings and replace the is not 0 with != 0 in the management.py file.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 24, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

zwass
zwass approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Sorry that osquery-python has not seen a lot of love recently.

I'm looking to release a new version soon.

@zwass zwass merged commit 451045e into osquery:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwass zwass zwass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bpmcdevitt @zwass