Skip to content

feat(static): reorder symbol table for better readability - #42

Merged
orhun merged 1 commit into
mainfrom
feat/change_symbol_ordering
Sep 19, 2024
Merged

feat(static): reorder symbol table for better readability#42
orhun merged 1 commit into
mainfrom
feat/change_symbol_ordering

Conversation

@orhun

@orhun orhun commented Sep 19, 2024

Copy link
Copy Markdown
Owner

Description of change

This PR updates the symbols and dynamic symbols table to have the following order:

  • Name, Type, Value, Size, Bind, Visibility, Ndx
  • Name, Requirements, Type, Value, Size, Bind, Visibility, Ndx

A followup to this might be using better constraints on the table for properly showing the lengthy symbol names.

How has this been tested? (if applicable)

Locally.

@orhun
orhun merged commit 3a7dec7 into main Sep 19, 2024
@orhun
orhun deleted the feat/change_symbol_ordering branch September 19, 2024 12:53
@codecov

codecov Bot commented Sep 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 3.48%. Comparing base (580c9ec) to head (8b78b7c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tui/ui.rs 0.00% 8 Missing ⚠️
src/elf/symbols.rs 0.00% 7 Missing ⚠️
src/elf/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #42      +/-   ##
========================================
- Coverage   3.50%   3.48%   -0.01%     
========================================
  Files         18      18              
  Lines       2317    2329      +12     
========================================
  Hits          81      81              
- Misses      2236    2248      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant