Skip to content

fix(tui): stop the event handler on quit - #24

Merged
orhun merged 1 commit into
mainfrom
fix/clean_up_terminal
Sep 17, 2024
Merged

fix(tui): stop the event handler on quit#24
orhun merged 1 commit into
mainfrom
fix/clean_up_terminal

Conversation

@orhun

@orhun orhun commented Sep 13, 2024

Copy link
Copy Markdown
Owner

Description of change

I realized we are not stopping the event handling loop when the restart command is send.

fixes #13

How has this been tested? (if applicable)

Locally.

@codecov-commenter

codecov-commenter commented Sep 13, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 3.67%. Comparing base (236d19e) to head (c3f4a0d).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #24      +/-   ##
========================================
- Coverage   3.67%   3.67%   -0.00%     
========================================
  Files         18      18              
  Lines       2212    2213       +1     
========================================
  Hits          81      81              
- Misses      2131    2132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun
orhun merged commit d42b670 into main Sep 17, 2024
@orhun
orhun deleted the fix/clean_up_terminal branch September 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: TUI crash after opening a dependency and then quitting binsider

2 participants