fix(test): ensure that binary is built before the test runs - #11
Merged
Conversation
13 tasks
Omega-Centauri-21
approved these changes
Sep 12, 2024
Omega-Centauri-21
left a comment
There was a problem hiding this comment.
These changes will improve the reliability and organization of the tests
orhun
reviewed
Sep 12, 2024
orhun
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! This is smart.
The `app.rs` test requires that the `binsider` binary has been built. By moving the test into the `tests` directory, `cargo` will ensure that the binary has been built before the test can be run.
samueltardieu
force-pushed
the
push-qzkwxolsrxyx
branch
from
September 12, 2024 09:25
21a50e2 to
93a2fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The
app.rstest requires that thebinsiderbinary has been built. By moving the test into thetestsdirectory,cargowill ensure that the binary has been built before the test can be run.How has this been tested? (if applicable)
By running
cargo testfrom a clean directory. It fails before this patch.Note that this does not fix another issue: the test will still fail when running
cargo test --releaseas it requires the binary to be available intarget/debug/.