[mdns] increase TxMessageHistory expire timeout#12129
[mdns] increase TxMessageHistory expire timeout#12129abtink wants to merge 1 commit intoopenthread:mainfrom
TxMessageHistory expire timeout#12129Conversation
This commit increases `TxMessageHistory::kExpireInterval` from 10 to 100 seconds. This interval determines how long information about previously transmitted mDNS messages from the MDNS module is retained. This history is used to detect whether a received message originates from the mDNS module itself. The increased interval safeguards against potentially longer delays on the platform side when receiving packets.
Library files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12129 +/- ##
==========================================
+ Coverage 72.67% 73.37% +0.70%
==========================================
Files 669 669
Lines 94045 95235 +1190
==========================================
+ Hits 68347 69879 +1532
+ Misses 25698 25356 -342
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request increases the expiration timeout for the mDNS transmitted message history from 10 to 100 seconds. This change is well-justified in the description, as it provides a larger buffer to handle potential platform-side delays in receiving packets, thus preventing the mDNS module from incorrectly treating its own messages as external. The increased timeout enhances the robustness of self-originating message detection. The change is straightforward and looks good.
There was a problem hiding this comment.
Pull Request Overview
This PR increases the TxMessageHistory expiration timeout from 10 to 100 seconds to better handle potential platform delays in packet reception. The transmission history is used to identify self-originating mDNS messages, and the increased timeout provides a wider safety margin against false negatives when platform delays in receiving packets are longer than expected.
- Increases
TxMessageHistory::kExpireIntervalconstant from 10 to 100 seconds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
We can close this. |
This commit increases
TxMessageHistory::kExpireIntervalfrom 10 to 100 seconds.This interval determines how long information about previously transmitted mDNS messages from the MDNS module is retained. This history is used to detect whether a received message originates from the mDNS module itself.
The increased interval safeguards against potentially longer delays on the platform side when receiving packets.