chore: initial typescript migration with unit and integration tests #22
Closed
muenchhausen wants to merge 2 commits intoopensourceBIM:masterfrom
Closed
chore: initial typescript migration with unit and integration tests #22muenchhausen wants to merge 2 commits intoopensourceBIM:masterfrom
muenchhausen wants to merge 2 commits intoopensourceBIM:masterfrom
Conversation
# Conflicts: # bimserverclient.ts # model.ts # translations_en.ts
rubendel
reviewed
Dec 3, 2018
Member
rubendel
left a comment
There was a problem hiding this comment.
Sorry but I don't feel comfortable merging this into master and basically changing the language of the API from JavaScript to TypeScript. It will brake all sort of things, for example local development since browsers don't understand TypeScript (last time I checked). I can imagine this to be a welcome branch to be used by people who are already using TypeScript in their projects. Would you mind putting it into a branch?
Author
|
I fully aggree. I have no access rights to create a branch in this repo. Can you create a branch where I create a pull request to? |
Member
|
Sure, created "typescript" |
Author
|
Pull Request is done for branch typescript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial proposal for TypeScript, unit- and integration testing support.
Integration tests run against BIMserver in a docker container on travis-ci.
Integration tests can be found currently here
https://travis-ci.org/muenchhausen/BIMserver-JavaScript-API
Your feedback is welcome!