Fix so SimStore tests pass without simtk.unit#957
Fix so SimStore tests pass without simtk.unit#957dwhswenson merged 1 commit intoopenpathsampling:masterfrom
Conversation
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Mon 28 Dec 14:00 GMT (15:00 local). NB: This particular issue is blocking the next release of the OPS CLI (which will include SimStore support!) and so I'll probably go ahead and release a 1.4.1 shortly after this is in. |
|
LGTM, 1 quick question: Is |
Sorry, the PR message wasn't clear. Two separate issues here:
|
Ah, thanks for the clarification! All looks good to me then :) |
Without
simtk.unitinstalled, SimStore wasn't working. We only test SimStore with full integrations (similar problem to #954).This also adds an
extrasfor SimStore, so (in future releases)pip install openpathsampling[simstore]will install the extra requirements for SimStore as well.