[WIP] Unproxy objects using .unproxy()#786
Open
jhprinz wants to merge 1 commit intoopenpathsampling:masterfrom
Open
[WIP] Unproxy objects using .unproxy()#786jhprinz wants to merge 1 commit intoopenpathsampling:masterfrom
.unproxy()#786jhprinz wants to merge 1 commit intoopenpathsampling:masterfrom
Conversation
.proxy().unproxy()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements / Resolves #671
This was not so difficult. There is now a method
which will convert recursively all existing LoaderProxies into real objects to avoid the problem of loading an object and have it implicitly requiring an open file where the object was loaded from.
There are specific implementations for
TrajectoryandSampleSetThere was also a little bug when getting delayed attributes which lead to returning the Proxy and not the full object. The user should not see the LoaderProxies unless specifically asking for it.