-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Description
Currently, we have a few modules that are extremely long and should be split into several modules in a subpackage. This would help new developers find their way to the relevant classes more easily.
The goals are:
- Do not change the API. Everything in the root
openpathsamplingnamespace should stay there. - Create shorter files. 1000 raw lines (including comments/docs/blanks) should be a rough maximum (this is a pylint suggestion, and one that I agree with).
- Create a clearer file structure for new devs.
Note that, at this point, I'm not proposing changing tests at all. I want all tests to pass with the only change being perhaps the way things are imported. Eventually, the tests should be also be reorganized so that there is one test module per code module, but I'm not planning to implement that now.
Tasks:
- Reorganize
ensemble.py - Reorganize
pathmover.py - Reorganize
movestrategy.py - Reorganize
pathsimulator.py(Split pathsimulator.py #754)
Others may also be added to this list later, but these are the ones where new devs are likely to be looking for models to implement their own things or to understand how the code works.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels