fix: empty user email on grpc metrics ingest #9608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a critical auth bug where gRPC metrics ingestion could result in empty user emails in usage reporting, and introduces a type-safe Key Changes:
Impact:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant C as Client
participant A as Auth Module
participant H as Handler
participant S as Service
participant R as Reporter
Note over C,R: User Flow
C->>A: Request
A->>A: Check auth
A->>H: Add metadata
H->>H: Create IngestUser
H->>S: Call service
S->>R: Report usage
Note over C,R: System Flow
participant J as Job
J->>H: Request
H->>H: Create IngestUser
H->>S: Call service
S->>R: Report usage
|
YashodhanJoshi1
approved these changes
Dec 11, 2025
Contributor
YashodhanJoshi1
left a comment
There was a problem hiding this comment.
lgtm.
Few nits, but can be ignored.
| .unwrap_or_default(); | ||
| .unwrap_or_else(|| { | ||
| log::warn!("[gRPC Metrics] user_id not found in metadata, using empty string"); | ||
| "" |
Contributor
There was a problem hiding this comment.
nit: instead of empty string should we use "unknown" ? Not a strong reason, but for some reason that feels better to me. Fine even if kept as is.
|
|
||
| let org_id = org_id.into_inner(); | ||
| let user_email = &user_email.user_id; | ||
| let user = IngestUser::from_user_email(&user_email.user_id); |
Contributor
There was a problem hiding this comment.
any particular reason here we use this method, but some places directly use IngestUser::User ?
nit: if possible let's use the same thing everywhere
Comment on lines
+512
to
513
| req_stats.user_email = if email_str.is_empty() { | ||
| None |
Contributor
There was a problem hiding this comment.
In this case instead of None, should we put "unknown" instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check auth can return req without populating metadata, this pr fixes the case and adds an
IngestUsertype to mark all system initiated ingestion calls and user initiated ingestion calls