Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

This PR fixes the issue in #9540

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 10, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 10, 2025

Greptile Overview

Greptile Summary

This PR fixes a regression bug (#9540) where typing search text to filter streams and then selecting a stream would result in both the search text and the selected stream name appearing together.

Changes made:

  • Modified handleSingleStreamSelect to remove the unnecessary check for inputValue existence before calling updateInputValue("")
  • Added hidePopup() call to close the dropdown menu after single stream selection

The fix correctly addresses the bug by:

  1. Always clearing the input value regardless of whether one exists (the previous condition inputValue && updateInputValue was overly restrictive)
  2. Closing the dropdown after selection, providing a cleaner UX

The implementation follows Quasar's QSelect API correctly and the change is minimal and targeted.

Confidence Score: 5/5

  • This PR is safe to merge - it's a minimal, targeted bug fix that correctly addresses the reported issue.
  • The change is small and focused on fixing a specific UI bug. It uses Quasar's documented QSelect API methods (updateInputValue and hidePopup) correctly. The logic change removes an unnecessary condition that was preventing the input from being cleared.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/plugins/logs/IndexList.vue 5/5 Fixed handleSingleStreamSelect to properly clear input value and close dropdown after selecting a single stream, resolving the bug where search text persisted after selection.

Sequence Diagram

sequenceDiagram
    participant User
    participant QSelect as q-select (streamSelect)
    participant Handler as handleSingleStreamSelect
    participant SearchObj as searchObj state

    User->>QSelect: Types "def" to filter streams
    QSelect->>QSelect: Shows filtered options (e.g., "default")
    User->>QSelect: Clicks on "default" label
    QSelect->>Handler: handleSingleStreamSelect({value: "default"})
    Handler->>SearchObj: selectedStream = ["default"]
    Handler->>QSelect: $nextTick callback
    QSelect->>QSelect: updateInputValue("") - clears search text
    QSelect->>QSelect: hidePopup() - closes dropdown
    Handler->>Handler: onStreamChange("")
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe force-pushed the fix/issue-9540 branch 3 times, most recently from 1cc5068 to ff52c8c Compare December 12, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants