Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

No description provided.

@nikhilsaikethe nikhilsaikethe force-pushed the fix/language-translations branch from fb6a707 to 317e6af Compare December 8, 2025 13:27
@github-actions github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 8, 2025

Greptile Overview

Greptile Summary

This PR completes the internationalization (i18n) effort by adding approximately 570 missing translation keys across the web application. The changes systematically replace hardcoded English strings in Vue components with proper i18n function calls (t()), and add corresponding translations to all 11 supported language files (en, de, es, fr, it, ja, ko, nl, pt, tr, zh).

Key Changes:

  • Added translation keys across multiple sections: common, alerts, reports, pipeline, logStream, functions, and about
  • Updated 56 Vue components to use i18n keys instead of hardcoded strings
  • Properly implemented parameter interpolation for dynamic values (e.g., {fileName}, {fieldName})
  • Moved aggregation key from middle to end of common section and added it to alerts section for better organization
  • All language files received properly localized translations (not just English text)

Quality Assessment:
The implementation follows Vue i18n best practices with proper use of the t() function, parameter interpolation syntax, and maintains consistent key naming conventions. The translations appear to be professionally localized rather than machine-translated placeholder text.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it's a straightforward internationalization update
  • The changes are well-structured and follow established i18n patterns. All hardcoded strings are replaced with proper translation keys, parameter interpolation is correctly implemented, and all 11 language files receive consistent updates. The scope is limited to UI text changes with no logic modifications, making it low-risk.
  • No files require special attention - all changes follow consistent patterns

Important Files Changed

File Analysis

Filename Score Overview
web/src/locales/languages/en.json 5/5 Added ~570 new translation keys across common, alerts, reports, pipeline, logStream, functions, and about sections for internationalization support
web/src/locales/languages/de.json 5/5 Added German translations for all new keys with proper localization
web/src/locales/languages/fr.json 5/5 Added French translations for all new keys with proper localization
web/src/locales/languages/ja.json 5/5 Added Japanese translations for all new keys with proper localization
web/src/components/alerts/AddAlert.vue 5/5 Replaced hardcoded strings with i18n translation keys using t() function for better internationalization support
web/src/components/common/BaseImport.vue 5/5 Replaced hardcoded error messages and UI strings with i18n keys, including proper parameter interpolation for dynamic values
web/src/components/pipeline/PipelineEditor.vue 5/5 Converted hardcoded strings to i18n keys throughout the component, including validation messages and notifications
web/src/components/reports/CreateReport.vue 5/5 Replaced hardcoded strings with i18n translation keys, including validation rules, labels, and tooltips
web/src/components/common/sidebar/FieldList.vue 5/5 Updated UI strings and notification messages to use i18n keys with proper parameter interpolation
web/src/views/About.vue 5/5 Replaced hardcoded strings with i18n keys for the About/License page features

Sequence Diagram

sequenceDiagram
    participant User
    participant VueComponent
    participant i18nPlugin
    participant LanguageFiles
    
    User->>VueComponent: Interacts with UI
    VueComponent->>i18nPlugin: t('common.jsonFilesOnly')
    i18nPlugin->>LanguageFiles: Lookup key in active locale
    alt Key exists
        LanguageFiles-->>i18nPlugin: Return translated string
        i18nPlugin-->>VueComponent: ".json files only" (en) or<br/>"nur.json-Dateien" (de)
    else Key missing (before this PR)
        LanguageFiles-->>i18nPlugin: Key not found
        i18nPlugin-->>VueComponent: Fallback to key or empty
    end
    VueComponent->>User: Display localized text
    
    Note over VueComponent,LanguageFiles: This PR adds 570+ missing keys<br/>to prevent fallback scenarios
    
    User->>VueComponent: Uses dynamic content (e.g., error)
    VueComponent->>i18nPlugin: t('common.errorParsingJsonFile',<br/>{fileName: 'data.json'})
    i18nPlugin->>LanguageFiles: Lookup key with params
    LanguageFiles-->>i18nPlugin: "Error parsing JSON from file {fileName}"
    i18nPlugin->>i18nPlugin: Interpolate {fileName} = 'data.json'
    i18nPlugin-->>VueComponent: "Error parsing JSON from file data.json"
    VueComponent->>User: Display error message
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

58 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe force-pushed the fix/language-translations branch from 92ad6a6 to 19f24a6 Compare December 8, 2025 16:15
@nikhilsaikethe nikhilsaikethe marked this pull request as draft December 8, 2025 17:19
@nikhilsaikethe nikhilsaikethe marked this pull request as ready for review December 8, 2025 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Failed to generate code suggestions for PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

68 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe force-pushed the fix/language-translations branch from ea0615b to 74e114d Compare December 9, 2025 05:32
@nikhilsaikethe nikhilsaikethe marked this pull request as draft December 10, 2025 04:55
nikhilsaikethe and others added 15 commits December 10, 2025 17:31
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
Auto-generated translation updates from English source file.

🤖 Generated with automated translation workflow
@nikhilsaikethe nikhilsaikethe force-pushed the fix/language-translations branch from 74e114d to 84ab150 Compare December 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working ✏️ Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants