fix: issue 9835 #9514
Open
fix: issue 9835 #9514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
bjp232004
approved these changes
Dec 8, 2025
Contributor
Greptile OverviewGreptile SummaryThis PR attempts to fix intermittent collapse/expand issues by adding watchers to prevent splitter values below 10px and only saving splitter positions >= 1px. However, the snap-back logic in three files contains a critical bug that prevents it from working. Key Changes:
Critical Issue: Confidence Score: 0/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Splitter as QSplitter Component
participant Watcher as splitterModel Watcher
participant State as Component State
User->>Splitter: Drags splitter from 200px to 180px
Splitter->>Watcher: Triggers watch(newValue=180, oldValue=200)
Watcher->>Watcher: Check: 180 >= 10? TRUE
Watcher->>State: Update lastSplitterPosition = 180
Watcher->>State: Set showSidebar = true
User->>Splitter: Continues dragging to 5px
Splitter->>Watcher: Triggers watch(newValue=5, oldValue=180)
Watcher->>Watcher: Check: 5 >= 10? FALSE
Watcher->>Watcher: Check: 5 > 0 && 5 < 10 && oldValue !== lastSplitterPosition?
Note over Watcher: BUG: oldValue(180) === lastSplitterPosition(180)
Note over Watcher: Condition evaluates to FALSE, no snap-back!
Watcher->>Watcher: Check: 5 === 0? FALSE
Note over Watcher: No action taken - splitter stays at 5px
User->>User: Clicks expand/collapse button
User->>State: Calls collapseSidebar()
State->>State: Toggle showSidebar
State->>Splitter: Set splitterModel to lastSplitterPosition(180) or 0
Note over User,Splitter: Collapse/expand stops working because<br/>splitter is stuck at invalid 5px position
|
Comment on lines
+335
to
+352
| } else if (newValue > 0 && newValue < 10 && oldValue !== (storePreviousStoreModel.value || 250)) { | ||
| // If dragged to less than 10px, snap back to last valid position | ||
| splitterModel.value = storePreviousStoreModel.value || 250; | ||
| showManagementTabs.value = true; |
Contributor
There was a problem hiding this comment.
logic: snap-back logic won't work as intended - when user drags from 200→5px, oldValue will be 200 (which equals storePreviousStoreModel.value since it was just updated on line 333), so the condition oldValue !== (storePreviousStoreModel.value || 250) evaluates to false and no snap-back occurs
Suggested change
| } else if (newValue > 0 && newValue < 10 && oldValue !== (storePreviousStoreModel.value || 250)) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = storePreviousStoreModel.value || 250; | |
| showManagementTabs.value = true; | |
| } else if (newValue > 0 && newValue < 10) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = storePreviousStoreModel.value || 250; | |
| showManagementTabs.value = true; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/components/settings/index.vue
Line: 335:338
Comment:
**logic:** snap-back logic won't work as intended - when user drags from 200→5px, `oldValue` will be 200 (which equals `storePreviousStoreModel.value` since it was just updated on line 333), so the condition `oldValue !== (storePreviousStoreModel.value || 250)` evaluates to false and no snap-back occurs
```suggestion
} else if (newValue > 0 && newValue < 10) {
// If dragged to less than 10px, snap back to last valid position
splitterModel.value = storePreviousStoreModel.value || 250;
showManagementTabs.value = true;
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+139
to
+142
| } else if (newValue > 0 && newValue < 10 && oldValue !== lastSplitterPosition.value) { | ||
| // If dragged to less than 10px, snap back to last valid position | ||
| splitterModel.value = lastSplitterPosition.value; | ||
| showSidebar.value = true; |
Contributor
There was a problem hiding this comment.
logic: snap-back logic won't work as intended - when user drags from a valid position to <10px, oldValue equals lastSplitterPosition.value (updated on line 137), so the condition oldValue !== lastSplitterPosition.value is always false
Suggested change
| } else if (newValue > 0 && newValue < 10 && oldValue !== lastSplitterPosition.value) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = lastSplitterPosition.value; | |
| showSidebar.value = true; | |
| } else if (newValue > 0 && newValue < 10) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = lastSplitterPosition.value; | |
| showSidebar.value = true; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/views/Functions.vue
Line: 139:142
Comment:
**logic:** snap-back logic won't work as intended - when user drags from a valid position to <10px, `oldValue` equals `lastSplitterPosition.value` (updated on line 137), so the condition `oldValue !== lastSplitterPosition.value` is always false
```suggestion
} else if (newValue > 0 && newValue < 10) {
// If dragged to less than 10px, snap back to last valid position
splitterModel.value = lastSplitterPosition.value;
showSidebar.value = true;
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+77
to
+80
| } else if (newValue > 0 && newValue < 10 && oldValue !== lastSplitterPosition.value) { | ||
| // If dragged to less than 10px, snap back to last valid position | ||
| splitterModel.value = lastSplitterPosition.value; | ||
| showSidebar.value = true; |
Contributor
There was a problem hiding this comment.
logic: snap-back logic won't work as intended - when user drags from a valid position to <10px, oldValue equals lastSplitterPosition.value (updated on line 74), so the condition oldValue !== lastSplitterPosition.value is always false
Suggested change
| } else if (newValue > 0 && newValue < 10 && oldValue !== lastSplitterPosition.value) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = lastSplitterPosition.value; | |
| showSidebar.value = true; | |
| } else if (newValue > 0 && newValue < 10) { | |
| // If dragged to less than 10px, snap back to last valid position | |
| splitterModel.value = lastSplitterPosition.value; | |
| showSidebar.value = true; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/views/IdentityAccessManagement.vue
Line: 77:80
Comment:
**logic:** snap-back logic won't work as intended - when user drags from a valid position to <10px, `oldValue` equals `lastSplitterPosition.value` (updated on line 74), so the condition `oldValue !== lastSplitterPosition.value` is always false
```suggestion
} else if (newValue > 0 && newValue < 10) {
// If dragged to less than 10px, snap back to last valid position
splitterModel.value = lastSplitterPosition.value;
showSidebar.value = true;
```
How can I resolve this? If you propose a fix, please make it concise.91f3df3 to
04b83da
Compare
04b83da to
c798673
Compare
c798673 to
980e216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr fixes the issue in #9385