-
Notifications
You must be signed in to change notification settings - Fork 711
fix: gc always running with zero released #9502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
uddhavdave
approved these changes
Dec 5, 2025
Contributor
Greptile OverviewGreptile SummaryThis PR fixes excessive GC logging by proportionally adjusting the Key changes:
Issues found:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GC as GC Task
participant Config as Config
participant FILES as FILES Cache
participant RESULT as RESULT_FILES Cache
participant AGG as AGGREGATION_FILES Cache
GC->>Config: get_config()
Config-->>GC: cfg
Note over GC: Process FILES
loop for each file in FILES
GC->>FILES: read()
FILES-->>GC: r (cur_size, max_size)
alt cur_size + release_size < max_size
Note over GC: Skip GC (cache not full)
else cache full
GC->>FILES: write().gc(gc_size)
FILES-->>GC: release bytes
end
end
Note over GC: Calculate proportional release_size
GC->>GC: release_size = max(10MB, release_size / (max_size / result_max_size))
Note over GC: Process RESULT_FILES
loop for each file in RESULT_FILES
GC->>RESULT: read()
RESULT-->>GC: r (cur_size, max_size)
alt cur_size + release_size < max_size
Note over GC: Skip GC (cache not full)
else cache full
GC->>RESULT: write().gc(gc_size)
RESULT-->>GC: release bytes
end
end
Note over GC: Calculate proportional release_size
GC->>GC: release_size = max(10MB, release_size / (max_size / aggregation_max_size))
Note over GC: Process AGGREGATION_FILES
loop for each file in AGGREGATION_FILES
GC->>AGG: read()
AGG-->>GC: r (cur_size, max_size)
alt cur_size + release_size < max_size
Note over GC: Skip GC (cache not full)
else cache full
GC->>AGG: write().gc(gc_size)
AGG-->>GC: release bytes
end
end
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
haohuaijin
approved these changes
Dec 5, 2025
Loaki07
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the case there are some logs keep output

The reason is the
ZO_DISK_CACHE_RELEASE_SIZEdefault is10%ofZO_DISK_CACHE_MAX_SIZE, andZO_DISK_RESULT_CACHE_MAX_SIZEalso is10%of it. so even there is no data, butcurr_size + release >= result_max_sizethen it start gc.