-
Notifications
You must be signed in to change notification settings - Fork 711
fix: no process-level CryptoProvider available #9361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryFixes a critical blocker bug where OpenObserve crashes on startup when TLS is enabled by installing the rustls ring
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Main as main()
participant Config as Configuration
participant Rustls as rustls::crypto::ring
participant HTTP as HTTP Server
participant GRPC as gRPC Server
participant TLS as TLS Module
Main->>Config: Load config from CLI/env
Config-->>Main: Return cfg
Note over Main,Rustls: NEW: Install CryptoProvider early
alt TLS enabled
Main->>Rustls: default_provider().install_default()
Rustls-->>Main: Provider installed
end
Main->>Main: Initialize backend jobs
Main->>Main: Initialize search service
alt HTTP TLS enabled
Main->>HTTP: Start HTTP server
HTTP->>TLS: http_tls_config()
TLS->>Rustls: ServerConfig::builder()
Note over Rustls: Uses already-installed provider
Rustls-->>TLS: TLS config
TLS-->>HTTP: ServerConfig
HTTP->>HTTP: bind_rustls_0_23()
else HTTP non-TLS
Main->>HTTP: Start HTTP server
HTTP->>HTTP: bind()
end
alt gRPC TLS enabled
Main->>GRPC: Start gRPC server
GRPC->>GRPC: Load cert/key
GRPC->>GRPC: tls_config()
Note over GRPC: Uses tonic TLS (also uses rustls internally)
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
YashodhanJoshi1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey one concern I have is that here we specify the ring as default provider, but for certain features like email we use aws_lc as the crypto provider (via feature flag) ; can the conflict and cause runtime error if someone tries to send report email (or our cloud related email invite code as well)
YashodhanJoshi1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with email client setup, works
fixed #9359