Merged
Conversation
PGijsbers
reviewed
Oct 19, 2020
PGijsbers
requested changes
Oct 19, 2020
Collaborator
PGijsbers
left a comment
There was a problem hiding this comment.
Please look at my suggested change and commit it if you feel it improves the PR. Either way works for me.
Collaborator
|
The docs suggest that this can be a string or a list. Should we maybe take you running into this issue as a reason to check if the attributes actually exist? |
Collaborator
|
Missed that detail of the original post. Agreed that we should also add a check to verify the attributes actually exist 👍 |
Co-authored-by: PGijsbers <p.gijsbers@tue.nl>
PGijsbers
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix? Explain your changes.
The dataset creation example did not explain how to add multiple ignore attributes.
I tried comma-separated but then the server doesn't recognize them (but also doesn't return an error).
It needs to be a list.