Conversation
mfeurer
requested changes
Oct 18, 2019
Collaborator
mfeurer
left a comment
There was a problem hiding this comment.
Yes, a test (using for example the minimal failing example) would be great.
Codecov Report
@@ Coverage Diff @@
## develop #851 +/- ##
===========================================
+ Coverage 88.41% 88.91% +0.49%
===========================================
Files 37 37
Lines 4271 4716 +445
===========================================
+ Hits 3776 4193 +417
- Misses 495 523 +28
Continue to review full report at Codecov.
|
mfeurer
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do I add a regression test?