Conversation
|
@mfeurer can you explain the restriction on the third part of the subcomponent? |
|
Please see my answer in #773 |
# Conflicts: # openml/extensions/sklearn/extension.py
|
@amueller shall I try taking this PR up? |
|
@mfeurer about 4/5 unit tests throw the following error when running on the latest sklearn version locally Also, I couldn't understand why for |
As it is typed optional it can actually be
Hm, apparently, the dummy imputor needs a docstring, otherwise the description uploaded to OpenML will be emptly. |
Codecov Report
@@ Coverage Diff @@
## develop #777 +/- ##
===========================================
- Coverage 88.57% 88.15% -0.43%
===========================================
Files 37 37
Lines 4324 4363 +39
===========================================
+ Hits 3830 3846 +16
- Misses 494 517 +23
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
This looks good to me by now :) I have added a few more comments, and I think there are few comments still open.
|
Thanks for addressing my change requests, that all looks good now. There are a few old comments though, which are collapsed and you need to press 'show more to see them, that would be great if you could have a look at them. We can then ask @PGijsbers for another look and finally merge this :) |
PGijsbers
left a comment
There was a problem hiding this comment.
Before I dive into the meat of this PR (which I will, with additional comments), I figured I would already add change requests/clarifications to get things moving :)
This tries to solve #773.
Still probably needs some handling for sparse datasets.