MRG Sklearn 0.21 compatibility and CI#752
Merged
mfeurer merged 19 commits intoopenml:developfrom Jul 26, 2019
Merged
Conversation
amueller
commented
Jul 25, 2019
amueller
commented
Jul 25, 2019
Contributor
Author
|
tests pass locally on 0.22.dev0, let's see what CI says |
Codecov Report
@@ Coverage Diff @@
## develop #752 +/- ##
===========================================
- Coverage 87.93% 87.84% -0.09%
===========================================
Files 36 37 +1
Lines 4086 4082 -4
===========================================
- Hits 3593 3586 -7
- Misses 493 496 +3
Continue to review full report at Codecov.
|
Contributor
Author
|
Not sure what's up with the dict on windows... |
mfeurer
reviewed
Jul 26, 2019
Collaborator
mfeurer
left a comment
There was a problem hiding this comment.
I think the Windows tests use Python3.5, and therefore, you're dicts are not sorted. Could that be the issue?
mfeurer
approved these changes
Jul 26, 2019
Contributor
Author
|
Thank you! Sweet :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #749.