Register pytest uses_test_server marker#1632
Register pytest uses_test_server marker#1632AniruthKarthik wants to merge 5 commits intoopenml:mainfrom
Conversation
geetu040
left a comment
There was a problem hiding this comment.
you should register this marker in pyproject.toml, where the previous markers are defined.
geetu040
left a comment
There was a problem hiding this comment.
@AniruthKarthik are you working on this? please update with your changes, currently these are no files being changed.
Sorry ! I had the changes staged locally but forgot to actually commit and push them. I've now pushed the fix 😅 |
fkiraly
left a comment
There was a problem hiding this comment.
fine in terms of logic - though in terms of naming, would test_server not be more in line? Although that would also mean changing the markers.
Sure, I am in favor of it. |
geetu040
left a comment
There was a problem hiding this comment.
@AniruthKarthik could you please rename uses_test_server to test_server everywhere?
Also remove server from the markers list in pyproject.toml, it's not being used anywhere now.
Hm, should the marker then not just be |
|
@PGijsbers who is sitting next to me is saying it is fine to remove @PGijsbers also thinks it is better to rename |
|
@fkiraly should i rename production to production_server ??? |
|
@AniruthKarthik, yes, that would be appreciated - please also the pytest markers |
|
@fkiraly Renamed production to production_server across CLI shorthands and pytest markers as discussed, and removed the unused server marker. Please review and merge. |
|
great! Could you also update in the |
| "server: anything that connects to a server", | ||
| "upload: anything that uploads to a server", | ||
| "production: any interaction with the production server", | ||
| "production_server: any interaction with the production server", |
|
@fkiraly I'll fix the indentation. There is no developer_setup.md , should i create one or update contribution.md ??? |
Please sync with |
There was a problem hiding this comment.
rename uses_test_server to test_server in this file.
Fixes PytestUnknownMarkWarning by registering the custom uses_test_server marker.
Related to #1631.