Conversation
Ubuntu tests only temporarily disabled for this PR, to avoid unnecessary computational costs/time.
The check is bash script, which means it fails on a Windows machine.
Closed
mfeurer
approved these changes
Jun 16, 2021
Collaborator
mfeurer
left a comment
There was a problem hiding this comment.
That's a really neat PR - removing lots of custom bash code. Thanks a lot!
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Add Windows to Github Action CI matrix * Fix syntax, disable Ubuntu tests Ubuntu tests only temporarily disabled for this PR, to avoid unnecessary computational costs/time. * Fix syntax for skip on install Python step * Explicitly add the OS to includes * Disable check for files left behind for Windows The check is bash script, which means it fails on a Windows machine. * Re-enable Ubuntu tests * Replace Appveyor with Github Actions for WindowsCI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Windows runner to Github CI, allows us to drop Appveyor (which has been broken for a while).
Things still broken/out of date that need to be updated (but I'd prefer them in separate PRs):