Conversation
The Parquet file is optional, and failing to reach it (and download it) should not prevent the usage of the other cached/downloaded files.
PGijsbers
commented
May 19, 2021
| parquet_file = _get_dataset_parquet(description) | ||
| try: | ||
| parquet_file = _get_dataset_parquet(description) | ||
| except urllib3.exceptions.MaxRetryError: |
Collaborator
Author
There was a problem hiding this comment.
I wasn't sure if I should be conservative here, or just catch all errors. Considering we haven't had any issues otherwise I went with the general best practice of only minimally catching exceptions.
mfeurer
approved these changes
May 19, 2021
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
The Parquet file is optional, and failing to reach it (and download it) should not prevent the usage of the other cached/downloaded files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1084.
The Parquet file is optional, and failing to reach it (and download it)
should not prevent the usage of the other cached/downloaded files.
To test run:
once with an internet connection, and once without. Both should work.