Conversation
mfeurer
reviewed
Apr 16, 2021
mfeurer
reviewed
Apr 21, 2021
mfeurer
reviewed
Apr 22, 2021
openml/datasets/dataset.py
Outdated
| if scipy.sparse.issparse(data): | ||
| return pd.DataFrame.sparse.from_spmatrix(data, columns=attribute_names) | ||
| data = pd.DataFrame.sparse.from_spmatrix(data, columns=attribute_names) | ||
| if isinstance(data, pd.DataFrame) and data.shape[1] == 1: |
Collaborator
There was a problem hiding this comment.
Is this necessary? Don't you also do this in get_data()? Also, I think it'll break the balloon datast which has only a single attribute.
mfeurer
approved these changes
Apr 26, 2021
PGijsbers
pushed a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Convert sparse labels to pandas series * Handling sparse labels as Series * Handling sparse targets when dataset as arrays * Revamping sparse dataset tests * Removing redundant unit test * Cleaning target column formatting * Minor comment edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses #1057.
What does this PR implement/fix? Explain your changes.
Adds a check when fetching and converting datasets that converts labels as sparse arrays to dataframes.
How should this PR be tested?