ignore plot_settings.pkl file if model is changed#94
Merged
paulromano merged 5 commits intoopenmc-dev:developfrom May 31, 2022
Merged
ignore plot_settings.pkl file if model is changed#94paulromano merged 5 commits intoopenmc-dev:developfrom
plot_settings.pkl file if model is changed#94paulromano merged 5 commits intoopenmc-dev:developfrom
Conversation
paulromano
reviewed
May 13, 2022
paulromano
requested changes
May 26, 2022
Contributor
Author
|
Don't merge this yet- I think moving the point at which the model settings are restored messed with some other things. If we check the whole file, then that doesn't need to be moved to the end anyway. So let me change that back. |
Contributor
Author
|
Now this should be good |
pshriwise
reviewed
May 31, 2022
pshriwise
approved these changes
May 31, 2022
Collaborator
pshriwise
left a comment
There was a problem hiding this comment.
Works like a charm for me! Thanks for tackling this @kkiesling
paulromano
approved these changes
May 31, 2022
Contributor
|
Thanks @kkiesling! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #77
If either the materials IDs or cell IDs are altered between when the GUI was last closed and when it is reopened with the
plot_settings.pklfile, this will ignore the settings file (previously this would cause an error).In order for this to work,
restoreModelSettings()has to be called after the cell and material IDs have been populated in the model (ie, after the plot model is no longer "frozen").Are there any other properties/model changes that could cause these errors that are not captured in cell IDs and mat IDs?