Improve performance of distribcell/cell instance tally plotting#89
Merged
pshriwise merged 1 commit intoopenmc-dev:developfrom Apr 29, 2022
Merged
Conversation
pshriwise
approved these changes
Apr 29, 2022
Collaborator
pshriwise
left a comment
There was a problem hiding this comment.
Thanks for this @paulromano! Nice to remove that performance bottleneck as a potential concern in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so I went to go add a comment about the suboptimal performance of our distribcell/cell instance plotting, but then found inspiration to just fix said suboptimal performance. With the changes here, we now compute the cell ID mask only once for each cell that is used in a
DistribcellFilterandCellInstanceFilter.