Support 2D meshes, energy function filter#64
Merged
pshriwise merged 4 commits intoopenmc-dev:developfrom Oct 25, 2021
Merged
Conversation
846c8bb to
3dd4818
Compare
330897a to
0843eb1
Compare
pshriwise
approved these changes
Oct 25, 2021
Collaborator
pshriwise
left a comment
There was a problem hiding this comment.
Thanks for the added capability @paulromano! An extra thank you for updating the CI along the way. 🙌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for plotting tally results when a mesh filter with a 2D mesh is used. I've also fixed a bug whereby a tally with an EnergyFunctionFilter would cause an exception to be raised.