Make items in filter list auto tristate#150
Merged
pshriwise merged 2 commits intoopenmc-dev:developfrom Jun 7, 2024
Merged
Conversation
Member
|
Oh this looks handy for shut down dose rate analysis, thanks Paul |
Contributor
Author
|
Just added one more fix for the cell/material highlight checkboxes in the color options dialog not working. |
pshriwise
approved these changes
Jun 7, 2024
Collaborator
pshriwise
left a comment
There was a problem hiding this comment.
LGTM. Thanks @paulromano!
Collaborator
I noticed that too yesterday. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a mesh tally with other filters on top, right now it's not possible to pick out specific bins from those other filters. After digging into this a while, I realized that the problem was that the top-level treewidget items were not being set to "auto tristate", which allows them to be partially checked based on the state of the child items. With this change, now you can select bins for these filters freely. In my particular use case, I'm combining a material filter with a mesh filter and want to plot the mesh results restricted to a particular material.