Update use of obsolete features in Qt5#123
Merged
kkiesling merged 1 commit intoopenmc-dev:developfrom Sep 28, 2023
Merged
Conversation
Contributor
|
Does this require any updates to the dependencies in the setup.py file? (ie specific minimum versions of packages?) |
Contributor
Author
|
Good question -- not that I'm aware of though. I think these are things that have long been deprecated/obsolete. |
kkiesling
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few things we use from Qt5 that are already obsolete (and are removed in Qt6). This PR will minimize the number of changes needed to move from PySide2 to PySide6.