Skip to content

Implement ui_locales parameter support. - #413

Merged
agologan merged 2 commits into
openid:masterfrom
ivan9jukic:feature/add-ui-locales-support
May 30, 2021
Merged

Implement ui_locales parameter support.#413
agologan merged 2 commits into
openid:masterfrom
ivan9jukic:feature/add-ui-locales-support

Conversation

@ivan9jukic

Copy link
Copy Markdown
Contributor

Implements #16

@codecov-io

codecov-io commented Sep 25, 2018

Copy link
Copy Markdown

Codecov Report

Merging #413 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #413      +/-   ##
============================================
+ Coverage     83.69%   83.78%   +0.08%     
- Complexity      478      479       +1     
============================================
  Files            42       42              
  Lines          2343     2356      +13     
  Branches        233      234       +1     
============================================
+ Hits           1961     1974      +13     
  Misses          299      299              
  Partials         83       83
Impacted Files Coverage Δ Complexity Δ
.../java/net/openid/appauth/AuthorizationRequest.java 93.52% <100%> (+0.53%) 14 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe9047...8750a52. Read the comment docs.

@mavdi

mavdi commented Nov 26, 2019

Copy link
Copy Markdown

Can this PR be merged? Is anything holding it up?

@agologan

agologan commented Feb 9, 2021

Copy link
Copy Markdown
Collaborator

@ivan9jukic I know this is an old contribution but could you please sign the CLA agreements https://github.com/openid/AppAuth-Android/blob/master/CONTRIBUTING.md

@arok

arok commented Mar 11, 2021

Copy link
Copy Markdown

Any updated on this?

@hnljp

hnljp commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Any updated on this?

Personally I simply use the already existing method setAdditionalParameters, to set "ui_locales" with a corresponding value.

@ivan9jukic
ivan9jukic force-pushed the feature/add-ui-locales-support branch from 8750a52 to f39922e Compare March 11, 2021 14:32
@ivan9jukic

Copy link
Copy Markdown
Contributor Author

@ivan9jukic I know this is an old contribution but could you please sign the CLA agreements https://github.com/openid/AppAuth-Android/blob/master/CONTRIBUTING.md

@agologan Done!

@agologan

agologan commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

Unfortunately I don't see your CLA listed. Do you mind linking it from the openid website?

@agologan
agologan merged commit 45589c7 into openid:master May 30, 2021
@cumcum8197

Copy link
Copy Markdown

45589c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants