Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Feature/images#72

Closed
PhantomReactor wants to merge 76 commits intoopencode-ai:mainfrom
PhantomReactor:feature/images
Closed

Feature/images#72
PhantomReactor wants to merge 76 commits intoopencode-ai:mainfrom
PhantomReactor:feature/images

Conversation

@PhantomReactor
Copy link
Contributor

@PhantomReactor PhantomReactor commented Apr 25, 2025

InShot_20250429_212847545.mp4

@kujtimiihoxha kujtimiihoxha self-requested a review April 30, 2025 10:49
@PhantomReactor
Copy link
Contributor Author

  • Will check 1st and 4th points
  • I agree with the second and third points. Should be addressed in last commit
  • I think most users wouldn't have images in their projects.

Adam and others added 2 commits May 1, 2025 12:49
* feat: themes

* feat: flexoki theme

* feat: onedark theme

* feat: monokai pro theme

* feat: opencode theme (default)

* feat: dracula theme

* feat: tokyonight theme

* feat: tron theme

* some small fixes

---------

Co-authored-by: Kujtim Hoxha <kujtimii.h@gmail.com>
@kujtimiihoxha
Copy link
Collaborator

@PhantomReactor I merged in #113 that adds support for custom themes, this caused conflicts and you need to probably update the dialog to now use the new approach to styling.

garrettladley and others added 2 commits May 1, 2025 12:55
* feat: test for getContextFromPaths

* fix: use testify
@PhantomReactor
Copy link
Contributor Author

Let me check

@PhantomReactor
Copy link
Contributor Author

PhantomReactor commented May 1, 2025

@kujtimiihoxha we can merge this. Please review

@kujtimiihoxha
Copy link
Collaborator

Yep will review today, sorry it took so long

@kujtimiihoxha
Copy link
Collaborator

kujtimiihoxha commented May 1, 2025

@PhantomReactor I will add a couple of things in a commit tomorrow, this looks SOOOOOOOO good I love it..

@kujtimiihoxha
Copy link
Collaborator

kujtimiihoxha commented May 2, 2025

@PhantomReactor I have ran git filter-repo --invert-paths --path opencode --force to try and remove the large files in the commit history (pulling down took some time)

Screenshot 2025-05-02 at 12 43 43

This caused these conflicts I will get this sorted out

@kujtimiihoxha
Copy link
Collaborator

@PhantomReactor I pushed some UI fixes that make it look a bit simpler. I also added the index number to the images when you are in delete mode.

There is still the issue with the commits containing large files 60mb we need to find a way to remove them from the history before we can merge this.

@kujtimiihoxha
Copy link
Collaborator

Basically when I pulled the branch locally it took a long time and I wondered why.

This is the command I ran

 git rev-list --objects --all --missing=print |
  git cat-file --batch-check='%(objecttype) %(objectname) %(objectsize) %(rest)' |
  sed -n 's/^blob //p' |
  sort --numeric-sort --key=2 |
  cut -c 1-12,41- |
  $(command -v gnumfmt || echo numfmt) --field=2 --to=iec-i --suffix=B --padding=7 --round=nearest

Can't remember where I found this tho..

@PhantomReactor
Copy link
Contributor Author

Let me check

@kujtimiihoxha
Copy link
Collaborator

@PhantomReactor wait, it looks like its not your branch...

@kujtimiihoxha
Copy link
Collaborator

Screenshot 2025-05-02 at 13 48 27 Yeah something is weird... Running the command in a fresh clone of opencode shows that those are not there.. I think it has something to do with your fork 🤔

@kujtimiihoxha
Copy link
Collaborator

@PhantomReactor let me try to fix this with squashing your commits. I will force push the changes back if you are OK with that?

@PhantomReactor
Copy link
Contributor Author

PhantomReactor commented May 2, 2025

@kujtimiihoxha i removed large files and created new branch. add your ui changes. we can close this and create new pr
#144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.