Skip to content

test(workbench): share setup for completing scans and exporting findings - #1413

Open
mldangelo-oai wants to merge 23 commits into
mainfrom
mdangelo/codex/reuse-scan-completion-export-fixtures
Open

mldangelo-oai wants to merge 23 commits into
mainfrom
mdangelo/codex/reuse-scan-completion-export-fixtures

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Tests for completing scans, preserving stopped results, and exporting findings repeat command arguments and saved-draft setup. Reuse shared helpers so each test can focus on its inputs and expected results.

Changes

Use the shared scan and workspace commands in completion, database, export, and paging scenarios. Reuse coverage and draft helpers. Keep the scenarios' explicit data and behavior assertions. Shared workspace setup and fixture-option cleanup are already on main; the remaining diff removes 238 net lines.

Testing

Recorded Python 3.12 runs used temporary repositories, SQLite databases, and workbench command subprocesses to verify that:

  • Completion binds results to the selected diff snapshot, repeated completion preserves sealed artifact bytes, and concurrent completion records a finding only once.
  • Invalid drafts remain repairable. Failed or canceled scans retain findings and JSON, CSV, and SARIF exports; changed sealed manifests and symlinked export directories are rejected.
  • A scan with 75 synthetic findings returns bounded, non-overlapping pages and can retrieve a selected finding beyond the first page.

The updated main-based branch passed all 237 focused tests with Python 3.12. Full-plugin Ruff lint and formatting, the SDK CI build, the plugin source compatibility check, and all 9 checker tests also passed. Repeat from plugins/codex-security with Python test dependencies installed:

python -m pytest -q --tb=short tests/test_workbench_completion_binding.py tests/test_workbench_db.py tests/test_workbench_db_exports.py

Cross-platform validation was not run locally.

Risk and rollout

Uses the Deep Scan startup and recovery fixtures from merged #1402, now in main. This changes test setup only. The main risk is accidentally changing fixture inputs for completion and exports; production commands and database behavior are unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T15:22:30.210874Z 13dacc3 New commits
🔒 Security Review ✅ Completed 2026-10-07T15:23:50.601600Z 13dacc3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reuse-deep-scan-bootstrap-fixtures branch from aa1aaee to f769f54 Compare October 7, 2026 05:22
@mldangelo-oai mldangelo-oai changed the title test(workbench): reuse scan completion and export fixtures test(workbench): share setup for completing scans and exporting findings Oct 7, 2026
Base automatically changed from mdangelo/codex/reuse-deep-scan-bootstrap-fixtures to main October 7, 2026 05:36
@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Oct 7, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d8ea5ba4ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants