Repository navigation
test(workbench): share setup for completing scans and exporting findings - #1413
Open
mldangelo-oai wants to merge 23 commits into
Open
mldangelo-oai wants to merge 23 commits into
mldangelo-oai wants to merge 23 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mldangelo-oai
force-pushed
the
mdangelo/codex/reuse-deep-scan-bootstrap-fixtures
branch
from
October 7, 2026 05:22
aa1aaee to
f769f54
Compare
Base automatically changed from
mdangelo/codex/reuse-deep-scan-bootstrap-fixtures
to
main
October 7, 2026 05:36
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests for completing scans, preserving stopped results, and exporting findings repeat command arguments and saved-draft setup. Reuse shared helpers so each test can focus on its inputs and expected results.
Changes
Use the shared scan and workspace commands in completion, database, export, and paging scenarios. Reuse coverage and draft helpers. Keep the scenarios' explicit data and behavior assertions. Shared workspace setup and fixture-option cleanup are already on main; the remaining diff removes 238 net lines.
Testing
Recorded Python 3.12 runs used temporary repositories, SQLite databases, and workbench command subprocesses to verify that:
The updated main-based branch passed all 237 focused tests with Python 3.12. Full-plugin Ruff lint and formatting, the SDK CI build, the plugin source compatibility check, and all 9 checker tests also passed. Repeat from
plugins/codex-securitywith Python test dependencies installed:Cross-platform validation was not run locally.
Risk and rollout
Uses the Deep Scan startup and recovery fixtures from merged #1402, now in main. This changes test setup only. The main risk is accidentally changing fixture inputs for completion and exports; production commands and database behavior are unchanged.
Public disclosure review