Skip to content

feat: Make the 3rd-party download robust in CI - #2172

Open
sndpl wants to merge 2 commits into
openMSX:masterfrom
sndpl:fix/thirdparty-download-retry
Open

sndpl wants to merge 2 commits into
openMSX:masterfrom
sndpl:fix/thirdparty-download-retry

Conversation

@sndpl

@sndpl sndpl commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Two independent fixes:

  • thirdparty_download.py had no retry: a single failed download aborts the whole Windows-VC build with a bare exit code 1. It now retries with a delay, and reports which URL failed.
  • zlib is fetched from zlib.net, which serves a ~12 KB HTML block page instead of the tarball — so the checksum check fails, consistently and only in CI. The download URL now points at the byte-identical GitHub release asset.

@MBilderbeek

Copy link
Copy Markdown
Member

Weird that the zlib change is needed. Why did it work fine so far?

Hmm, it was recently (Jun 6 18:11:57 2025, c9d7862) changed to zlib.net, and used to be coming from downloads.sourceforge.net/libpng... Not sure if that's a good source nowadays.

@sndpl

sndpl commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

no clue, but each time the Windows VC build failed was because the download of zlib failed. I first added the retry, but after 3 retries it still failed until I changed the download location. The strange thing is that locally I couldn't reproduce it, it downloads the correct file from the zlib.net. But somehow it fails to download it in the CI.

@MBilderbeek

MBilderbeek commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Weird that the zlib change is needed. Why did it work fine so far?

Hmm, it was recently (Jun 6 18:11:57 2025, c9d7862) changed to zlib.net, and used to be coming from downloads.sourceforge.net/libpng... Not sure if that's a good source nowadays.

@grauw do you remember why you changed that link?
EDIT: Oh, I guess the commit message tells us that.... no more releases on the original URL then? Nope..

@grauw

grauw commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What is the content of that 12 KB HTML page?

Presumably it will tell you why the desired content was not served?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants