Add type annotations for registerLiveChecks imports#10258
Draft
Lang-Qiu wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
registerLiveChecksfunctions imported in the test file lacked explicit type definitions, which could lead to type unsafety and reduced IDE support, such as incorrect autocompletion or error detection.Changes
Added JSDoc type annotations to the two
registerLiveChecksimports. The annotations specify that each function accepts atestFnparameter of typeFunctionand returnsvoid, improving type safety and developer experience without altering functionality.Verification
These changes are minimal and non-breaking. They can be verified by reviewing the annotations for correctness, ensuring the code passes existing tests, and confirming improved IDE behavior (e.g., better type inference).