tools: adding IoT Connection Tools and ISD code samples#9
Merged
anjgola merged 3 commits intooneapi-src:masterfrom Aug 4, 2020
Propanu:master
Merged
tools: adding IoT Connection Tools and ISD code samples#9anjgola merged 3 commits intooneapi-src:masterfrom Propanu:master
anjgola merged 3 commits intooneapi-src:masterfrom
Propanu:master
Conversation
Signed-off-by: Mihai Tudor Panu <mihai.tudor.panu@intel.com>
pmpeter1
reviewed
Jul 7, 2020
pmpeter1
left a comment
There was a problem hiding this comment.
I'd suggest this be reviewed according to ISD coding guidelines. It does not conforn to DPC++ direct coding guidelines, and I doubt it should.
mkitez
suggested changes
Jul 7, 2020
Contributor
mkitez
left a comment
There was a problem hiding this comment.
@Propanu please add the ciTests field in all sample.json files according to https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
Signed-off-by: Mihai Tudor Panu <mihai.tudor.panu@intel.com>
anjgola
previously approved these changes
Jul 20, 2020
…orial Signed-off-by: Mihai Tudor Panu <mihai.tudor.panu@intel.com>
JoeOster
approved these changes
Jul 23, 2020
Contributor
JoeOster
left a comment
There was a problem hiding this comment.
All the typical things are in place, no windows stuff, readme.md are fine, all of the licenses are 2020, json is in place
mkitez
approved these changes
Aug 4, 2020
keylbill
added a commit
to keylbill/oneAPI-samples
that referenced
this pull request
Oct 28, 2022
Forgot to comment out line oneapi-src#9, "warm up".
jimmytwei
pushed a commit
to jimmytwei/oneAPI-samples
that referenced
this pull request
Mar 29, 2023
Fix missing bracket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Tudor Panu mihai.tudor.panu@intel.com