SIMD, BLD: Backport FPMATH mode on x86-32 and filter successor CPU features #30026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems I need a rebase to get rid of linter errors, as PR #30029 merged. |
…atures Two major bugs need to be merged as part of numpygh-28896 and must be fixed: - Force SSE-based floating-point on 32-bit x86 systems to avoid x87 FPU's 80-bit internal precision causing unpredictable rounding and overflow behavior when converting to smaller types. - Fix filtering out successor features when an implied feature is filterd out from `max` within build options `--cpu-baseline` and `--cpu-dispatch`. Documentation `build-options` has been updated for this case. - Updates `build-options` to add missing explanation about option `detect`.
1acc1dc to
18c3655
Compare
Member
|
Thanks Sayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major bugs need to be merged as part of gh-28896 and must be fixed:
Force SSE-based floating-point on 32-bit x86 systems to avoid x87 FPU's 80-bit internal precision causing unpredictable rounding and overflow behavior when converting to smaller types.
Fix filtering out successor features when an implied feature is removed through build options
--cpu-baselineand--cpu-dispatch. Documentationbuild-optionshas been updated for this case.Updates
build-optionsto add missing explanation about optiondetect.Please, see this comment for more details.