API: Remove np.ctypeslib.ctypes_load_library
#17116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcd2986 to
d852ecb
Compare
This function has been deprecated since fcee1ad (Numpy v1.0b3). 14 years is more than enough time for users to switch from it.
d852ecb to
caa70ea
Compare
Member
|
This was missing from the deprecation tracking issue gh-11521, maybe because the deprecation was done via wrapping with |
Member
|
Hah, nice, thanks Eric. |
eric-wieser
commented
Aug 20, 2020
| @@ -0,0 +1,2 @@ | |||
| * The 14-year deprecation of ``np.ctypeslib.ctypes_load_library`` is expired. | |||
| Use :func:`~numpy.ctypeslib.load_library` instead, which is identical. | |||
Member
Author
There was a problem hiding this comment.
Note that we seem to have two different styles of .expired notes - bullets and headers. I'm inclined to leave unifying them to when we release.
Member
There was a problem hiding this comment.
Yeah, we can see that later, a mix may even be OK as well (I am not sure how long the bullet ones are). I was just looking if I ignore Travis here, and I think I will, its bogged down for ages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has been deprecated since fcee1ad (Numpy v1.0b3).
14 years is more than enough time for users to switch from it.