MAINT: Remove nickname from polynomial classes. #16589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convenience classes derived from ABCPolyBase had a nickname attribute that was only used internally in the previous implementation of __str__. After the overhaul of __str__ in numpy#15666, this attr is no longer used.
Contributor
Author
|
re-trigger CI |
Member
|
@rossbar I think we should go ahead with it unless anyone speaks up. Its undocument, so the only one relying on it would be someone who creates new polynomials and even then it is very unlikely to affect them (worst case they have to replace the |
Add release note to notify users of removal of the abstract property, and highlight users that may be affected by the change.
Contributor
Author
|
Thanks for the feedback @seberg! I added a release note that summarizes the change and highlights users whom the change may affect. |
Member
|
Thanks Ross, lets put it in now, if anyone complains before the next release we can still undo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of proposed cleanup following the changes to polynomial printing in #15666.
The convenience classes derived from ABCPolyBase have a
nicknameattribute that was only used internally in the previous implementation of__str__. After the overhaul of__str__in #15666, this attr is no longer used anywhere internally, nor is it documented.This change would technically break backward compatibility as the attribute was not prepended with
_, but as it was an undocumented attribute that was only used internally in one specific place (and is no longer used anywhere) I thought it might be worth at least considering its removal.