Conversation
Proc now multi-targets net11.0 and picks up a few of the Process API improvements from that release, all gated behind NET11_0_OR_GREATER and no-ops elsewhere: - SendControlC delivers SIGINT on Unix via SafeProcessHandle.Signal instead of shelling out to `kill`. - New KillOnParentExit and InheritedHandles options on StartArguments/ExecArguments, wired into ProcessStartInfo. - EventBasedObservableProcess reads through Process.ReadAllLinesAsync. Also simplifies BufferedObservableProcess's stream reading on netstandard2.1/net8.0/net10.0/net11.0, dropping the hand-rolled CancellableStreamReader now that StreamReader.ReadAsync has a native cancellable overload on those TFMs (the class is kept for netstandard2.0/net461). Proc.Tests.Binary is now published as a NativeAOT executable and invoked directly in tests instead of via `dotnet <dll>`, removing dotnet-host/JIT startup variance from process-lifecycle tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net11.0alongside the existing TFMs (pinned viaglobal.jsonto the preview SDK, CI updated to install it).NET11_0_OR_GREATERand no-ops elsewhere:SendControlCdeliversSIGINTon Unix viaSafeProcessHandle.Signalinstead of shelling out tokill.KillOnParentExitandInheritedHandlesoptions onStartArguments/ExecArguments, wired intoProcessStartInfo.EventBasedObservableProcessreads throughProcess.ReadAllLinesAsync.BufferedObservableProcess's stream reading onnetstandard2.1/net8.0/net10.0/net11.0, dropping the hand-rolledCancellableStreamReadernow thatStreamReader.ReadAsynchas a native cancellable overload on those TFMs (kept fornetstandard2.0/net461).Proc.Tests.Binaryas a NativeAOT executable and invoke it directly in tests instead ofdotnet <dll>, removing dotnet-host/JIT startup variance from process-lifecycle tests, and add coverage for the new behaviors (KillOnParentExit, UnixSendControlC).Test plan
./build.sh build— full solution builds cleanly across all TFMs../build.sh test— full suite passes on bothnet10.0(48 passed) andnet11.0(50 passed), with expected Windows-only/KillOnParentExit-on-macOS skips.Made with Cursor