Updated NSubstitute to v5 for modern TFMs - #690
Merged
Merged
Conversation
…Framework.ReferenceAssemblies to stable version
Havunen
commented
May 22, 2022
dtchepak
self-requested a review
May 23, 2022 02:14
Member
|
@Havunen Thanks a lot for this! LGTM 👍 @zvirja @alexandrnikitin Please let me know if you have any issues with this PR. |
Contributor
Author
|
If this PR gets merged and new version published to Nuget, then I could deprecate my fork https://www.nuget.org/packages/NSubstituteNet6/ 😉 |
Member
|
This has been released in 4.4.0. Please confirm it is all ok 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Castle.Core to v5 for modern TFMs, also updated Microsoft.NET.Framework.ReferenceAssemblies to stable version.
NSubstitute changed their TFM support in v5 release. https://www.nuget.org/packages/Castle.Core/5.0.0#dependencies-tab
This PR fixes: #673