Skip to content

Redirect option + image file url bug fix + video & div support#269

Open
moogamouth wants to merge 10 commits into
nsfw-filter:masterfrom
moogamouth:master
Open

Redirect option + image file url bug fix + video & div support#269
moogamouth wants to merge 10 commits into
nsfw-filter:masterfrom
moogamouth:master

Conversation

@moogamouth

@moogamouth moogamouth commented Feb 18, 2025

Copy link
Copy Markdown

Changes

Added a "redirect" option that redirects to about:blank, fixed filtering for image file urls, added video and div support.

Fixes # (issue)
This extension did not work on image file urls (example.com/image.png), now it does.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@pottekkat
pottekkat requested review from a team, pottekkat and yzevm February 18, 2025 03:47
@yzevm

yzevm commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

@moogamouth hi, thanks for PR, whats CPU and RAM on your machine? I just worry that it will be work slow for some users

@moogamouth

moogamouth commented Feb 18, 2025

Copy link
Copy Markdown
Author

11th Gen Intel(R) Core(TM) i3-1115G4 @ 3.00GHz 2.90 GHz, 8 GB RAM no GPU. Also I'm not super experienced with pull requests so I didn't realize that my new commits automatically got added to the request.

@moogamouth moogamouth changed the title Redirect option + image file url bug fix Redirect option + image file url bug fix + video support Feb 18, 2025
@yzevm

yzevm commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

@moogamouth great, to be honest, I didnt touch this repo for 1-2 years, so I need time to setup environment and check you PR. If I haven't any new till Feb 20 evening, it means that I'll check in March(I have vacation where internet doesn't work). Please ping me March 2 if I forget =(

@moogamouth

moogamouth commented Feb 18, 2025

Copy link
Copy Markdown
Author

I just stupidly deleted a comment where I said that we need a CORS proxy. I'm just going to use a CORS proxy service.

@yzevm

yzevm commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

I'm realizing that my commit is creating CORS errors on certain sites. The only solution to this is probably a proxy. Should we host our own proxy or use a service?

Yeah, I faced with similar error, looks like we should have toggle for this feature

@moogamouth moogamouth changed the title Redirect option + image file url bug fix + video support Redirect option + image file url bug fix + video & div support Feb 24, 2025
@Exosylver

Copy link
Copy Markdown

@yzevm have you looked to approve the pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants