docs(update): Replace comma with period in run on sentence#7142
docs(update): Replace comma with period in run on sentence#7142wraithgar merged 2 commits intonpm:latestfrom
Conversation
- I also removed the word "direct" in the phrase "direct dependencies." To be honest, I'm not sure if this change was correct; I don't know what the differences between a "dependency" and a "direct dependency," and I'm hoping to learn through feedback on this PR. - If "direct" means "not transitive," I don't think any clarity is lost by my modification. I'd even argue this change adds clarity and may expose a missing detail: what happens to transitive dependencies when you `npm update`? Of course, that question is built on top of assumptions; I'm hoping that sharing what I was thinking at the time could help others in reviewing my change.
|
"direct" is indeed correct; something that is not direct is "transitive", meaning, it's not listed in package.json, and I think it's important to convey that it's only referring to listed deps. |
Because without the word "direct," users will think Since my original assumptions were correct, I'm also curious about this question: what happens to transitive dependencies when you |
|
I think the presence of the word causes zero harm if it's redundant, and prevents nonzero harm if it's not. That's a good question - I'm relatively sure they're updated on disk, as if you |
I replaced a comma with period in run on sentence.
I also removed the word "direct" in the phrase "direct dependencies." To be honest, I'm not sure if this change was correct; I don't know what the differences between a "dependency" and a "direct dependency," and I'm hoping to learn through feedback on this PR.
npm update? Of course, that question is built on top of assumptions; I'm hoping that sharing what I was thinking at the time could help others in reviewing my change.References
https://docs.npmjs.com/cli/v10/commands/npm-update