Incorrect multi-threading synchronization in UpdateDatabaseState#6114
Merged
NinoFloris merged 1 commit intonpgsql:mainfrom Oct 29, 2025
Merged
Conversation
vonzshik
approved these changes
May 22, 2025
Contributor
vonzshik
left a comment
There was a problem hiding this comment.
Thanks, that indeed looks wrong.
Now, this shouldn't be critical as we pretty much always overwrite the state due to passing DateTime.UtcNow as timeStamp, but for the sake of being consistent it's probably better to fix in 9.0 and 8.0.
As for 10.0, I'll probably take a look at removing timeStamp from here.
Member
|
Backported to 9.0.5 via cd9a7ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix for an apparent bug in
NpgsqlDataSource.UpdateDatabaseState. The volatile field is being copied into a variable, but then the field is still being accessed later.