Merged
Conversation
vonzshik
approved these changes
Nov 19, 2024
roji
approved these changes
Nov 19, 2024
roji
pushed a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 1d93236)
eerhardt
reviewed
Nov 19, 2024
| readonly Type[] _jsonClrTypes = jsonClrTypes ?? []; | ||
| TypeInfoMappingCollection? _mappings; | ||
|
|
||
| #if NET9_0_OR_GREATER |
Contributor
There was a problem hiding this comment.
Did you mean to multi-target for net9.0? As of right now, this code is dead since this project doesn't have a net9.0 target.
Member
There was a problem hiding this comment.
Yep, we're aware - this is just to make sure we get the proper thing if and when we do target net9.0+ (and won't use reflection...).
This was referenced Nov 23, 2025
Merged
This was referenced Dec 29, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 30, 2026
This was referenced Feb 9, 2026
This was referenced Feb 20, 2026
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed offline.